lib: prefix macros UNUSED and FALLTHROUGH#7309
Conversation
echoix
left a comment
There was a problem hiding this comment.
Read fast on all files, looks fine.
How will we communicate the changes?
Is there something to adapt for the ctypegen python bindings?
What bugs me a bit is that we can't really rely on the Doxygen docs to show the change, as it is only one version for all grass8, and it kinda changes a lot. Like, we wouldn't know for grass8.4 what was possible?
It is supposed to be of internal use, so I think not necessary.
No, this is for c/c++ compiler only.
Thanks, doxygen needs to be updated, just pushed a commit! Otherwise the macro is only to silence compiler warnings. |
Prefix the preprocessing macros
UNUSEDandFALLTHROUGHwithG_to avoid conflicts with third party software.This is something I have long planned to do. For example, there was an issue for QGIS, which they solved in qgis/QGIS#55018; one of the addons was also affected OSGeo/grass-addons#1626.