Skip to content

Update manifest and packages for Outlook-event-sso-naa sample#1138

Open
davidchesnut wants to merge 2 commits intomainfrom
davech-pack1
Open

Update manifest and packages for Outlook-event-sso-naa sample#1138
davidchesnut wants to merge 2 commits intomainfrom
davech-pack1

Conversation

@davidchesnut
Copy link
Copy Markdown
Member

  • Switches sample to unified manifest.
  • updates package versions.

Comment on lines +24 to +25
"outline": "assets/icon-64.png",
"color": "assets/icon-128.png"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"outline" has to be a 32x32 image and "color" has to be a 192x192 image. You can copy the "color.png" and "outline.png" from any Teams app project or add-in project created with ATK. Copy them into the /assets folder of this project and then update these two filenames.

{
"id": "onNewMessageComposeHandler",
"type": "executeFunction",
"displayName": "onNewMessageComposeHandler",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this line. "displayName" is only used for add-ins that have custom keyboard shortcuts, which aren't supported in Outlook.

Suggested change
"displayName": "onNewMessageComposeHandler",

{
"id": "onNewAppointmentComposeHandler",
"type": "executeFunction",
"displayName": "onNewAppointmentComposeHandler",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"displayName": "onNewAppointmentComposeHandler",

{
"id": "action_1",
"type": "openPage",
"displayName": "action_1",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"displayName": "action_1",

{
"id": "action_2",
"type": "openPage",
"displayName": "action_2",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"displayName": "action_2",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants