Skip to content

feat: support gcc h and dod clouds and skip teams app related actions#15572

Open
HuihuiWu-Microsoft wants to merge 7 commits intoOfficeDev:devfrom
HuihuiWu-Microsoft:gcch-and-dod-support
Open

feat: support gcc h and dod clouds and skip teams app related actions#15572
HuihuiWu-Microsoft wants to merge 7 commits intoOfficeDev:devfrom
HuihuiWu-Microsoft:gcch-and-dod-support

Conversation

@HuihuiWu-Microsoft
Copy link
Copy Markdown
Contributor

Feature: https://msazure.visualstudio.com/Microsoft%20Teams%20Extensibility/_workitems/edit/36995382/?view=edit

Screenshot:
[Note: take 'GCC M' as example for testing as preauth is not done by service yet and blocks e2e test]
When user provision:
image

When user publish:
image

@HuihuiWu-Microsoft
Copy link
Copy Markdown
Contributor Author

@summzhan Please help review the strings and UX.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.26%. Comparing base (ce7b951) to head (82d6c9c).
⚠️ Report is 31 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##              dev   #15572    +/-   ##
========================================
  Coverage   89.26%   89.26%            
========================================
  Files         622      622            
  Lines       38107    38131    +24     
  Branches     7766     7561   -205     
========================================
+ Hits        34015    34037    +22     
- Misses       1987     1988     +1     
- Partials     2105     2106     +1     
Files with missing lines Coverage Δ
packages/fx-core/src/common/accountUtils.ts 72.72% <100.00%> (ø)
...fx-core/src/component/driver/teamsApp/configure.ts 95.65% <100.00%> (+0.41%) ⬆️
...es/fx-core/src/component/driver/teamsApp/create.ts 93.33% <100.00%> (-1.91%) ⬇️
...src/component/driver/teamsApp/publishAppPackage.ts 90.54% <100.00%> (+0.39%) ⬆️
...rc/component/driver/teamsApp/validateAppPackage.ts 89.61% <100.00%> (+0.42%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@summzhan
Copy link
Copy Markdown
Contributor

I didn't see the corresponding strings in the file changes hence comment here instead of comment inline.

"Skipping teamsApp/create as target env GCC M is not supported" is misleading and not accurate, giving the wrong impression this step is skipped without doing anything, but in fact in this action ATK is generating ID locally right? Suggest following:

"teamsApp/create generates Teams app ID locally instead of calling Developer Portal API since the API is not yet available in GCC H/DoD"

The other two suggest to change to:
"Skipping XXX as the required Developer Portal API is not yet available in GCC H and DoD."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants