feat: support gcc h and dod clouds and skip teams app related actions#15572
feat: support gcc h and dod clouds and skip teams app related actions#15572HuihuiWu-Microsoft wants to merge 7 commits intoOfficeDev:devfrom
Conversation
|
@summzhan Please help review the strings and UX. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #15572 +/- ##
========================================
Coverage 89.26% 89.26%
========================================
Files 622 622
Lines 38107 38131 +24
Branches 7766 7561 -205
========================================
+ Hits 34015 34037 +22
- Misses 1987 1988 +1
- Partials 2105 2106 +1
🚀 New features to boost your workflow:
|
|
I didn't see the corresponding strings in the file changes hence comment here instead of comment inline. "Skipping teamsApp/create as target env GCC M is not supported" is misleading and not accurate, giving the wrong impression this step is skipped without doing anything, but in fact in this action ATK is generating ID locally right? Suggest following: "teamsApp/create generates Teams app ID locally instead of calling Developer Portal API since the API is not yet available in GCC H/DoD" The other two suggest to change to: |
Feature: https://msazure.visualstudio.com/Microsoft%20Teams%20Extensibility/_workitems/edit/36995382/?view=edit
Screenshot:

[Note: take 'GCC M' as example for testing as preauth is not done by service yet and blocks e2e test]
When user provision:
When user publish:
