Fix Component Governance alert: Upgrade underscore from 1.12.1 to 1.13.8#3024
Fix Component Governance alert: Upgrade underscore from 1.12.1 to 1.13.8#3024
Conversation
size-limit report 📦
|
There was a problem hiding this comment.
Pull request overview
Upgrades the underscore dependency override to address a component governance security alert, updating the root dependency override and regenerating the pnpm lockfile accordingly.
Changes:
- Bumped
underscoreoverride from1.12.1to1.13.8in rootpackage.json. - Regenerated
pnpm-lock.yamlto resolve and pinunderscore@1.13.8. - Added a Beachball change file recording the security-related dependency upgrade.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Updates the pnpm override to force underscore@1.13.8. |
| pnpm-lock.yaml | Reflects the resolved underscore@1.13.8 version and integrity in the lockfile. |
| change/@microsoft-teams-js-a8f7b2c1-5d4e-4a9c-8b3f-7c6e9d2a1b5e.json | Adds a patch change entry documenting the security-driven upgrade. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "string_decoder": "^1.3.0", | ||
| "tar": ">=6.2.1", | ||
| "tough-cookie": "^4.1.3", | ||
| "underscore": "1.12.1", | ||
| "underscore": "1.13.8", | ||
| "url-parse": "^1.5.0", | ||
| "word-wrap": "^1.2.4", |
There was a problem hiding this comment.
The pnpm overrides-explanation section documents why each override exists, but there is no entry for the underscore override. Since this PR updates the override version for a security alert, please add an underscore key under pnpm.overrides-explanation describing the reason and any relevant context (e.g., the component governance/vulnerability motivation) so future maintainers know why it’s pinned.
There was a problem hiding this comment.
@sunbrk I think this is a good idea too, but given this is a security concern I support merging now and keeping an ADO item tracked to follow up on this.
| "string_decoder": "^1.3.0", | ||
| "tar": ">=6.2.1", | ||
| "tough-cookie": "^4.1.3", | ||
| "underscore": "1.12.1", | ||
| "underscore": "1.13.8", | ||
| "url-parse": "^1.5.0", | ||
| "word-wrap": "^1.2.4", |
There was a problem hiding this comment.
@sunbrk I think this is a good idea too, but given this is a security concern I support merging now and keeping an ADO item tracked to follow up on this.
Description
This PR upgrades the
underscoredependency from version 1.12.1 to 1.13.8 to resolve a component governance security alert.Changes Made
underscoreversion inpackage.jsonoverrides section from1.12.1to1.13.8pnpm-lock.yamlto reflect the updated dependency versionWhy This Change is Needed
Files Modified
package.json- Updated underscore version in overridespnpm-lock.yaml- Lock file updated viapnpm installValidation
Validation performed:
pnpm installUnit Tests added:
No
End-to-end tests added:
No
Additional Requirements
Change file added:
Yes