Make conjure#client_on_load option control nREPL popup on Clojure file open#760
Make conjure#client_on_load option control nREPL popup on Clojure file open#760parkuman wants to merge 1 commit intoOlical:mainfrom
conjure#client_on_load option control nREPL popup on Clojure file open#760Conversation
|
This will be very useful to some users. There is an existing configuration item called
So, instead of adding I've implemented something similar in the Python client's |
84dc7b6 to
b4b8d53
Compare
Nice! I like the idea of re-using that. Updated. |
connection.connect_on_load option to suppress nREPL popup on file openconjure#client_on_load option control nREPL popup on Clojure file open
|
@parkuman, I can't and don't speak for @Olical but I think he would prefer to leave the default for At this point with your PR, only the Python, SQL, Snd-S7, JavaScript, and Clojure clients would obey this setting. |
b4b8d53 to
e9f2806
Compare
|
@russtoku I might be misunderstanding, but the default for |
…ile open Users might be interested in suppressing the nREPL connection popup when first loading a Clojure file. This makes the setting `conjure#client_on_load` controllable by users to turn that auto connection off.
e9f2806 to
e2020a8
Compare
Sorry for the confusion. That was a typo. The default is |
|
Am I misunderstanding something or can we not get the same behavior by seeing |
|
@Olical Ah you're right. I didn't realize that the central gate was in In that case, it seems to me that the JS, SQL, Python clients might not need the second redundant check. Removing the second check locally for the JS client and loading a file i saw the same behaviour with and without that check. |
Oh, me, too! You just helped me as well. 😄
OK, I've work to do to clean up the clients that I mentioned. Thanks for your help and working with things! |
Overview
Users might be interested in suppressing the nREPL connection popup when first loading a Clojure file. I personally found it quite distracting, especially when just quickly trying to read a Clojure file with no intention of starting a REPL to do work.
This commit makes the setting
conjure#client_on_loadcontrol that auto nREPL connection on or off. Note that when set tofalse, Conjure will still auto connect when a form is evaluated as noted in the configuration text file. You can also see it in action in the demo video.Demo
Before:
Screen.Recording.2026-03-09.at.5.42.36.PM.mov
With
client_on_loadset tofalseScreen.Recording.2026-03-09.at.5.44.11.PM.mov
Notice I load the file and the connection popup doesn't appear. Only when I evaluate a form does it appear, and you can see it still auto connects.
p.s.
I am very open to suggestions! This is just something about Conjure I found particularly annoying and I would love to see it merged.