test(Common): add tests for Types/BaseDatabase/AggregationIntervalUtil#2584
Open
suvvvv wants to merge 1 commit into
Open
test(Common): add tests for Types/BaseDatabase/AggregationIntervalUtil#2584suvvvv wants to merge 1 commit into
suvvvv wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds unit tests for
AggregationIntervalUtilinCommon/Types/BaseDatabase/AggregationIntervalUtil.ts, which previously had no test coverage. This util is the single source of truth for which time-bucket size the analytics aggregate API uses for a given query window (shared by the server statement generator and browser chart code).Covered:
getAggregationIntervalForWindow— the full threshold ladder with inclusive-boundary checks: ≤3h → Minute, ≤7d → Hour, ≤6w → Day, ≤6mo → Week, ≤6y → Month, else Year. Includes the exact-boundary cases (3h, 7d, 6w) and just-over-boundary cases, plus a monotonicity check that the interval only widens as the window grows.getAggregationIntervalMs— each interval maps to its nominal millisecond width, and the widths are strictly increasing.Why
Improves test coverage for the
Common/Typesutilities (part of the broader test-coverage effort). The boundary tests pin down the exact<=cut-offs so a future refactor can't silently shift a bucket size.Testing
All 20 tests pass. The file is Prettier-clean.