Skip to content

test(Common): add tests for Types/BaseDatabase/AggregationIntervalUtil#2584

Open
suvvvv wants to merge 1 commit into
OneUptime:masterfrom
suvvvv:test/aggregation-interval-util
Open

test(Common): add tests for Types/BaseDatabase/AggregationIntervalUtil#2584
suvvvv wants to merge 1 commit into
OneUptime:masterfrom
suvvvv:test/aggregation-interval-util

Conversation

@suvvvv

@suvvvv suvvvv commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

What

Adds unit tests for AggregationIntervalUtil in Common/Types/BaseDatabase/AggregationIntervalUtil.ts, which previously had no test coverage. This util is the single source of truth for which time-bucket size the analytics aggregate API uses for a given query window (shared by the server statement generator and browser chart code).

Covered:

  • getAggregationIntervalForWindow — the full threshold ladder with inclusive-boundary checks: ≤3h → Minute, ≤7d → Hour, ≤6w → Day, ≤6mo → Week, ≤6y → Month, else Year. Includes the exact-boundary cases (3h, 7d, 6w) and just-over-boundary cases, plus a monotonicity check that the interval only widens as the window grows.
  • getAggregationIntervalMs — each interval maps to its nominal millisecond width, and the widths are strictly increasing.

Why

Improves test coverage for the Common/Types utilities (part of the broader test-coverage effort). The boundary tests pin down the exact <= cut-offs so a future refactor can't silently shift a bucket size.

Testing

node node_modules/.bin/jest --runInBand ./Tests/Types/BaseDatabase/AggregationIntervalUtil.test.ts

All 20 tests pass. The file is Prettier-clean.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@simlarsen

Copy link
Copy Markdown
Contributor

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants