Open
Conversation
The code itself is correct since the addiu instruction sign-extends.
fenhl
added
Type: Bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
MW_SEND_OWN_ITEMSflag of the co-op context introduced in #1691 has always had the limitation that certain types of locations aren't reported since they don't use the regular get item code. Songs are one of those types of locations (if “songs as items” is off). This PR fixes that.Since I wasn't able to figure out a way to run code when a song is learned, the fix is implemented by running a check every frame to compare the set of obtained songs with the set of reported songs. This code only runs when enabled by the multiworld plugin, so it shouldn't cause any unnecessary performance drops when it's not required.
This PR also fixes a couple minor documentation errors that I noticed while implementing this.