Fix MQ DC Staircase silver rupees shared flag#2504
Open
rrealmuto wants to merge 1 commit intoOoTRandomizer:Devfrom
Open
Fix MQ DC Staircase silver rupees shared flag#2504rrealmuto wants to merge 1 commit intoOoTRandomizer:Devfrom
rrealmuto wants to merge 1 commit intoOoTRandomizer:Devfrom
Conversation
fenhl
added
Type: Bug
Collaborator
|
I went through MQ DC and also didn't manage to trigger using switch flag 0x1C |
GSKirox
approved these changes
Dec 31, 2025
cjohnson57
reviewed
Apr 4, 2026
| if world.dungeon_mq['Dodongos Cavern']: # Patch DC MQ Staircase Transition Actor to use permanent switch flag 0x1F | ||
| rom.write_byte(0x1F12190 + 15, 0x9F) | ||
| if world.dungeon_mq['Dodongos Cavern']: # Patch DC MQ Staircase Transition Actor to use permanent switch flag 0x1C | ||
| rom.write_byte(0x1F12190 + 15, 0x9C) |
Collaborator
There was a problem hiding this comment.
It says 0x9C in the write_byte call instead of 0x1C
cjohnson57
added
Status: Waiting for Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue that was introduced with silver rupee shuffle. We changed the flag on the door in the MQ Dodongos Cavern to use a permanent switch flag 0x1F if silver rupees are shuffled. However, flag 0x1F is already in use by the bombable wall that leads to the lower right hallway, before the lower lizalfos. Basically, if you blow up that wall, the silver rupee door will automatically open and stay open regardless of how many silver rupees you have found for that room.
This PR changes that flag to a hopefully unused one - 0x1C
Testing
I ran through MQ DC and did everything that I could to try to set all of the scene flags. I ended up with the scene flags as EF364FFF
so 0x1C should be good but would be good for someone else to confirm. You can inspect the current scene's switch flags at memory address 0x801CA1C8
I didn't test actually collecting the silver rupees :)