Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
|
Coverage Impact This PR will not change total coverage. Modified Files with Diff Coverage (1)
🛟 Help
|
There was a problem hiding this comment.
Pull request overview
This PR fixes CMake generator-expression parsing issues caused by unescaped > characters inside compile-definition values, aligning behavior with CMake’s $<ANGLE-R> escape to prevent malformed command-line output (issue #211).
Changes:
- Escape
>as$<ANGLE-R>when formatting compile definition values. - Add a unit test covering
>escaping inListCompileDefinitions. - Update the GolangCI-Lint install link in
DEVELOPING.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/maker/buildcontent.go | Escapes > in compile definition values to keep generator expressions well-formed. |
| pkg/maker/buildcontent_test.go | Adds coverage verifying > is escaped to $<ANGLE-R> in formatted defines. |
| DEVELOPING.md | Refreshes GolangCI-Lint installation documentation link. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Fixes
>is not escaped in generator expressions #211Changes
Checklist