Skip to content

Escape > in defines#442

Merged
jthuangarm merged 1 commit intomainfrom
cbuild2cmake-EscapeDefines
Mar 10, 2026
Merged

Escape > in defines#442
jthuangarm merged 1 commit intomainfrom
cbuild2cmake-EscapeDefines

Conversation

@jthuangarm
Copy link
Collaborator

@jthuangarm jthuangarm commented Mar 10, 2026

Fixes

Changes

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@github-actions
Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@qltysh
Copy link

qltysh bot commented Mar 10, 2026

Qlty

Coverage Impact

This PR will not change total coverage.

Modified Files with Diff Coverage (1)

RatingFile% DiffUncovered Line #s
Coverage rating: B Coverage rating: B
pkg/maker/buildcontent.go100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@jthuangarm jthuangarm requested a review from Copilot March 10, 2026 15:39
@github-actions
Copy link
Contributor

Test Results

  6 files  ±0   18 suites  ±0   1s ⏱️ ±0s
 99 tests +1   99 ✅ +1  0 💤 ±0  0 ❌ ±0 
594 runs  +6  594 ✅ +6  0 💤 ±0  0 ❌ ±0 

Results for commit 9ea4d95. ± Comparison against base commit 99be429.

Copy link
Collaborator

@brondani brondani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jthuangarm jthuangarm merged commit 8916303 into main Mar 10, 2026
77 of 80 checks passed
@jthuangarm jthuangarm deleted the cbuild2cmake-EscapeDefines branch March 10, 2026 15:43
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes CMake generator-expression parsing issues caused by unescaped > characters inside compile-definition values, aligning behavior with CMake’s $<ANGLE-R> escape to prevent malformed command-line output (issue #211).

Changes:

  • Escape > as $<ANGLE-R> when formatting compile definition values.
  • Add a unit test covering > escaping in ListCompileDefinitions.
  • Update the GolangCI-Lint install link in DEVELOPING.md.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
pkg/maker/buildcontent.go Escapes > in compile definition values to keep generator expressions well-formed.
pkg/maker/buildcontent_test.go Adds coverage verifying > is escaped to $<ANGLE-R> in formatted defines.
DEVELOPING.md Refreshes GolangCI-Lint installation documentation link.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants