Hover info on Setup node and correct error type (#1385)#2321
Merged
brondani merged 1 commit intoOpen-CMSIS-Pack:mainfrom Jan 14, 2026
Merged
Hover info on Setup node and correct error type (#1385)#2321brondani merged 1 commit intoOpen-CMSIS-Pack:mainfrom
brondani merged 1 commit intoOpen-CMSIS-Pack:mainfrom
Conversation
Test Results 3 files 21 suites 13m 59s ⏱️ Results for commit 5485353. |
brondani
approved these changes
Jan 14, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2321 +/- ##
=======================================
Coverage 66.36% 66.37%
=======================================
Files 181 181
Lines 36737 36777 +40
Branches 22867 22887 +20
=======================================
+ Hits 24380 24410 +30
- Misses 7627 7633 +6
- Partials 4730 4734 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing: #2315
VS Code uses an internal schema resolution engine to determine what hover text to show. When schemas have ambiguous matches (e.g. oneOf, $ref, or combinators), the language server may not choose a single effective path so it doesn’t show specific description/title. Also the language service has known limitations around hover text.
In the specific case of
setupnode since the change include use ofallofinstead ofoneof. It shouldn't make any change since we have only of ref to be complaint with.