RPC: Tolerate non-critical errors when loading solution#2404
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the ProjMgr RPC LoadSolution behavior to treat certain solution-loading errors as non-fatal, aligning RPC mode with the goal of continuing operation even when the input solution has issues.
Changes:
- Stop using the boolean return value of
ProjMgr::LoadSolution()as the RPC success criterion. - Determine RPC load success based on whether contexts were populated after attempting to load/process the solution.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Test Results 3 files 21 suites 15m 34s ⏱️ Results for commit dba5eca. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2404 +/- ##
=======================================
Coverage 64.69% 64.69%
=======================================
Files 145 145
Lines 26113 26122 +9
Branches 15761 15765 +4
=======================================
+ Hits 16893 16900 +7
Misses 7068 7068
- Partials 2152 2154 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
For RPC case we can tolerate loading solution with errors like typos in access sequences, missing packs and schema violations.