Skip to content

RPC: Tolerate non-critical errors when loading solution#2404

Merged
edriouk merged 3 commits intomainfrom
RPC_LoadSolution_Tolearate
Mar 18, 2026
Merged

RPC: Tolerate non-critical errors when loading solution#2404
edriouk merged 3 commits intomainfrom
RPC_LoadSolution_Tolearate

Conversation

@edriouk
Copy link
Collaborator

@edriouk edriouk commented Mar 18, 2026

For RPC case we can tolerate loading solution with errors like typos in access sequences, missing packs and schema violations.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the ProjMgr RPC LoadSolution behavior to treat certain solution-loading errors as non-fatal, aligning RPC mode with the goal of continuing operation even when the input solution has issues.

Changes:

  • Stop using the boolean return value of ProjMgr::LoadSolution() as the RPC success criterion.
  • Determine RPC load success based on whether contexts were populated after attempting to load/process the solution.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@edriouk edriouk requested a review from brondani March 18, 2026 16:40
Copy link
Collaborator

@brondani brondani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

Test Results

    3 files     21 suites   15m 34s ⏱️
  453 tests   453 ✅ 0 💤 0 ❌
1 359 runs  1 359 ✅ 0 💤 0 ❌

Results for commit dba5eca.

@edriouk edriouk merged commit 5e83c84 into main Mar 18, 2026
31 of 33 checks passed
@edriouk edriouk deleted the RPC_LoadSolution_Tolearate branch March 18, 2026 17:00
@codecov
Copy link

codecov bot commented Mar 18, 2026

Codecov Report

❌ Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.69%. Comparing base (18b0ef8) to head (dba5eca).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tools/projmgr/src/ProjMgrRpcServer.cpp 81.81% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2404   +/-   ##
=======================================
  Coverage   64.69%   64.69%           
=======================================
  Files         145      145           
  Lines       26113    26122    +9     
  Branches    15761    15765    +4     
=======================================
+ Hits        16893    16900    +7     
  Misses       7068     7068           
- Partials     2152     2154    +2     
Flag Coverage Δ
projmgr-cov 87.71% <81.81%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/projmgr/src/ProjMgrRpcServer.cpp 85.19% <81.81%> (-0.13%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants