Skip to content

Add support for glob patterns in PACK_DELETE_FILES#95

Merged
JonatanAntoni merged 1 commit intomainfrom
pack-delete-files-with-globstar
Jan 14, 2026
Merged

Add support for glob patterns in PACK_DELETE_FILES#95
JonatanAntoni merged 1 commit intomainfrom
pack-delete-files-with-globstar

Conversation

@JonatanAntoni
Copy link
Member

@JonatanAntoni JonatanAntoni commented Jan 14, 2026

Adress shortcomings introduced by #92 fixing #86

@qltysh
Copy link

qltysh bot commented Jan 14, 2026

Qlty

Coverage Impact

⬆️ Merging this pull request will increase total coverage on main by 0.60%.

Modified Files with Diff Coverage (2)

RatingFile% DiffUncovered Line #s
Coverage rating: F Coverage rating: F
gen-pack95.0%142
Coverage rating: C Coverage rating: B
lib/helper100.0%
Total97.0%
🤖 Increase coverage with AI coding...

In the `pack-delete-files-with-globstar` branch, add test coverage for this new code:

- `gen-pack` -- Line 142

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@JonatanAntoni JonatanAntoni force-pushed the pack-delete-files-with-globstar branch from 619e394 to a57932e Compare January 14, 2026 13:47
@JonatanAntoni JonatanAntoni force-pushed the pack-delete-files-with-globstar branch from a57932e to eabe254 Compare January 14, 2026 13:49
@JonatanAntoni JonatanAntoni requested a review from furbanc January 14, 2026 14:05
Copy link

@furbanc furbanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I tested it in my local environment and it works as expected.

@JonatanAntoni JonatanAntoni merged commit 6520078 into main Jan 14, 2026
14 checks passed
@JonatanAntoni JonatanAntoni deleted the pack-delete-files-with-globstar branch January 14, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants