Data Exchange - Add animation support to XCAF document structure#492
Open
dpasukhi wants to merge 2 commits intoOpen-Cascade-SAS:IRfrom
Open
Data Exchange - Add animation support to XCAF document structure#492dpasukhi wants to merge 2 commits intoOpen-Cascade-SAS:IRfrom
dpasukhi wants to merge 2 commits intoOpen-Cascade-SAS:IRfrom
Conversation
- Introduced XCAFAnimObjects_Translate class for handling translation operations in animations. - Implemented XCAFDoc_Animation and XCAFDoc_AnimationTool classes to manage animation attributes and operations. - Updated CMake files to include new animation-related source and header files. - Enhanced the animation tool with methods for managing frame rates, time codes, and shape associations. - Added functionality to serialize and deserialize animation data within the XCAF document structure.
dpasukhi
added
2. Enhancement
ikochetkova
reviewed
Apr 11, 2025
Contributor
ikochetkova
left a comment
ikochetkova
left a comment
There was a problem hiding this comment.
I have a couple of remarks about comments, please have a look.
| //! @return Standard_GUID identifying the animation tool | ||
| Standard_EXPORT static const Standard_GUID& GetID(); | ||
|
|
||
| //! Creates (if does not exist) or retrieves an animation tool from the XCAFDoc at label L. |
Contributor
There was a problem hiding this comment.
seems the name in the comment was left after the code rules applying: label L -> the given label
|
|
||
| //! Sets the length unit used in the file. | ||
| //! @param theLengthUnit Length unit value to set | ||
| Standard_EXPORT void SetFileLengthUnit(const double theLengthUnit) const; |
Contributor
There was a problem hiding this comment.
I think saving this parameter needs more explanation in the comments. Now, it looks very strange to store file length units at the level of animation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.