Modeling - Update function handling in GeomFill_ConstrainedFilling and GeomFill_CoonsAlgPatch#922
Open
dpasukhi wants to merge 1 commit intoOpen-Cascade-SAS:IRfrom
Open
Modeling - Update function handling in GeomFill_ConstrainedFilling and GeomFill_CoonsAlgPatch#922dpasukhi wants to merge 1 commit intoOpen-Cascade-SAS:IRfrom
dpasukhi wants to merge 1 commit intoOpen-Cascade-SAS:IRfrom
Conversation
Member
dpasukhi
commented
Dec 15, 2025
dpasukhi
commented
- Changed the way functions are set in GeomFill_ConstrainedFilling to use SetFunc for improved clarity.
- Corrected parameter usage in GeomFill_CoonsAlgPatch::Value to ensure proper variable assignment for curve evaluation.
…d GeomFill_CoonsAlgPatch - Changed the way functions are set in GeomFill_ConstrainedFilling to use SetFunc for improved clarity. - Corrected parameter usage in GeomFill_CoonsAlgPatch::Value to ensure proper variable assignment for curve evaluation.
Member
Author
dpasukhi
added
the
1. Modeling
There was a problem hiding this comment.
Pull request overview
This PR addresses two separate issues in the GeomFill module related to parameter handling and function management:
- Corrects parameter usage in
GeomFill_CoonsAlgPatch::Valuewhere the second blending function was incorrectly using parameter V instead of U - Refactors function handling in
GeomFill_ConstrainedFilling::Initto useSetFuncinstead of reassigning and passing the same variables, improving code clarity
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/ModelingAlgorithms/TKGeomAlgo/GeomFill/GeomFill_CoonsAlgPatch.cxx | Fixes parameter assignment bug where a[1]->Value() now correctly uses U instead of V |
| src/ModelingAlgorithms/TKGeomAlgo/GeomFill/GeomFill_ConstrainedFilling.cxx | Refactors to use new variables for transformed functions and calls SetFunc instead of Func for improved clarity |
| Standard_Real a0, a1, a2, a3; | ||
| a0 = a[0]->Value(V); | ||
| a1 = a[1]->Value(V); | ||
| a1 = a[1]->Value(U); |
There was a problem hiding this comment.
The corrected parameter usage from V to U for a[1]->Value() represents a significant algorithmic change in the Coons patch evaluation. This change should be covered by a test case that verifies the correct blending behavior with different U and V parameters to ensure the patch is properly interpolated.
AtheneNoctuaPt
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.