Skip to content

Enhancement image url check#1207

Merged
HaiHui886 merged 1 commit into
mainfrom
sync_mr_2657_a36a342
Jun 25, 2026
Merged

Enhancement image url check#1207
HaiHui886 merged 1 commit into
mainfrom
sync_mr_2657_a36a342

Conversation

@csg-pr-bot

@csg-pr-bot csg-pr-bot commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Summary:

  • Replaced URL suffix validation with HTTP HEAD request metadata inspection to support image uploads to Alibaba Cloud OSS that lack file extensions.
  • Added internal IP and 302 redirect checks to prevent potential security attacks during image URL verification.

@csg-pr-bot

csg-pr-bot commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator Author

Depends on #1206

HaiHui886
HaiHui886 approved these changes Jun 25, 2026
View reviewed changes

@HaiHui886 HaiHui886 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@HaiHui886 HaiHui886 merged commit 38ff1b0 into main Jun 25, 2026
7 checks passed
@HaiHui886 HaiHui886 deleted the sync_mr_2657_a36a342 branch June 25, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HaiHui886 HaiHui886 HaiHui886 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@csg-pr-bot @HaiHui886 @pulltheflower