Add Chrome browser test container #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@baszoetekouw @pmeulen can I add this as-is or should this be moved to the containers repo, or a separate Dockerfile in this project? This is needed for functional tests in for example GW to test multiple and simultaneous flows in a browser. |
pmeulen
approved these changes
May 6, 2025
Member
pmeulen
left a comment
pmeulen
left a comment
There was a problem hiding this comment.
Looks fine to me. This change is limited to the "smoketest" profile, so the container won't be there when starting the stepup devconf environment normally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs discussion on how this can be added to devconf so the functional tests in GW can run fully automated.
Do we for example need a dedicated image on
ghcr.io/openconext/openconext-basecontainersso this could be easily pulled on a per project basis?