Show SP service name from mdui:UIInfo on authentication page and push notification - #411
Open
kayjoosten wants to merge 2 commits into
Open
Show SP service name from mdui:UIInfo on authentication page and push notification#411kayjoosten wants to merge 2 commits into
kayjoosten wants to merge 2 commits into
Conversation
Users currently see a generic authentication page and push notification when a service provider sends its display name via mdui:UIInfo. That loses useful context during the second-factor flow and leaves the new metadata support in Gateway and the GSSP bundle unused. Resolve the service name from the SAML metadata, format it for display, and surface it consistently in the browser and Tiqr notification path. The dependency pins keep the required bundle changes available until those branches are replaced by tagged releases. - show the resolved service name on the authentication page - include the formatted name in Tiqr push notifications - pin the required bundle branches and lockfile updates Resolves: #401
kayjoosten
force-pushed
the
feature/issue-401-display-name-from-saml
branch
from
July 10, 2026 11:15
b1bcef7 to
72b84e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #401.
mdui:DisplayNamein amdui:UIInfoSAML extension on the AuthnRequest sent to Tiqr (Stepup-Gateway#624).StateHandlerInterface::getMdui()(Stepup-gssp-bundle#49).tiqr/tiqr-server-libphpalready supports aserviceNameparam onsendAuthNotification)Service name processing rules
en, then first available language.…if longer.Dependency note
composer.jsontemporarily pinssurfnet/stepup-gssp-bundleandsurfnet/stepup-saml-bundleto their mdui feature branches (Stepup-gssp-bundle#49 / Stepup-saml-bundle#137), same as Stepup-Webauthn#273. These pins (and the accompanyingaudit.ignoreentries) need to be swapped for tagged releases before this merges.Test plan
composer phpstancleancomposer phpcscleancomposer phpmdcleancomposer unit-tests— 77 passing, including newServiceNameFormatterTest/ServiceNameResolverTestand extendedAuthenticationNotificationControllerTest