fix: add base class to exception #347
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavel-kirienko
approved these changes
Apr 24, 2025
Member
pavel-kirienko
left a comment
pavel-kirienko
left a comment
There was a problem hiding this comment.
Thank you, this is good. Please bump the patch version number in version.py, as described in CONTRIBUTING.md (you should read that)
Contributor
Author
|
Hm, I'm not sure if this is a major change. If I consider |
Member
|
It's worthy of a patch version bump only, since this is a fix that doesn't affect backward compatibility of the API |
pycyphal.application.file.RemoteFileError was introduced as common exception base class/tag type to catch exceptions resulting from remote file operations using the Cyphal remote file system interface. In Python exceptions must inherit from BaseException, otherwise a TypeError will occur: TypeError: exceptions must derive from BaseException RemoteFileError does not inherit from BaseException and can't thus be used in except clauses. This fix lets RemoteFileError inherit from RuntimeError, so that RemoteFileError can be used as intended. this fixes commit 40e1482 Signed-off-by: Hannes Weisbach <[email protected]>
hannesweisbach
force-pushed
the
fix-remote-file-exception
branch
from
0849126 to
f9eb722
Compare
pavel-kirienko
approved these changes
Apr 25, 2025
Member
|
Thank you! I have moved your commit to the |
pavel-kirienko
added a commit
that referenced
this pull request
May 12, 2025
…emo.rst; add USBtingo CAN FD support (#352) - #348 - #347 - #344 --------- Signed-off-by: Hannes Weisbach <[email protected]> Co-authored-by: d <[email protected]> Co-authored-by: Hannes Weisbach <[email protected]> Co-authored-by: Lasse Fröhner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pycyphal.application.file.RemoteFileError was introduced as common exception base class/tag type to catch exceptions resulting from remote file operations using the Cyphal remote file system interface.
In Python exceptions must inherit from BaseException, otherwise a TypeError will occur:
TypeError: exceptions must derive from BaseException
RemoteFileError does not inherit from BaseException and can't thus be used in except clauses.
This fix lets RemoteFileError inherit from RuntimeError, so that RemoteFileError can be used as intended.
this fixes commit 40e1482