Skip to content

Add simulation scenario concept #2071#2125

Open
schwarzatoffis wants to merge 11 commits intodevfrom
feature-2071-add-simulation-scenario
Open

Add simulation scenario concept #2071#2125
schwarzatoffis wants to merge 11 commits intodevfrom
feature-2071-add-simulation-scenario

Conversation

@schwarzatoffis
Copy link
Contributor

@schwarzatoffis schwarzatoffis commented Sep 30, 2025

Summary of the discussion

Add concept for description of simulation scenarios.

closes #2071

Type of change (CHANGELOG.md)

Add

  • Added new classes simulation scenario, simulation configuration, create output objective, and output data creation objective #2071

Update

Remove

Workflow checklist

Automation

Closes #

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@stap-m stap-m added this to Issues Sep 30, 2025
@github-project-automation github-project-automation bot moved this to Review in progress in Issues Sep 30, 2025
@schwarzatoffis schwarzatoffis marked this pull request as draft October 14, 2025 14:32
@schwarzatoffis schwarzatoffis marked this pull request as ready for review February 4, 2026 09:08
@github-actions github-actions bot added the oeo-model changes the oeo-model module label Feb 4, 2026
@github-actions
Copy link

github-actions bot commented Feb 4, 2026

Changed axioms per ontology

Note: Changes in term tracker annotations are not displayed

oeo-co-sim.omn: 0 changes

Ontologies are identical

oeo-model.omn: 19 changes

Ontology comparison

Left

  • Ontology IRI: https://openenergyplatform.org/ontology/oeo/oeo-model/
  • Version IRI: https://openenergyplatform.org/ontology/oeo/dev/oeo-model.omn
  • Loaded from: file:/__w/ontology/ontology/./dev/src/ontology/edits/oeo-model.omn

Right

  • Ontology IRI: https://openenergyplatform.org/ontology/oeo/oeo-model/
  • Version IRI: https://openenergyplatform.org/ontology/oeo/dev/oeo-model.omn
  • Loaded from: file:/__w/ontology/ontology/src/ontology/edits/oeo-model.omn

Ontology imports

Ontology annotations

output creation objective https://openenergyplatform.org/ontology/oeo/OEO_00420002

Added

output data creation objective https://openenergyplatform.org/ontology/oeo/OEO_00420003

Added

simulation configuration https://openenergyplatform.org/ontology/oeo/OEO_00420001

Added

simulation plan specification https://openenergyplatform.org/ontology/oeo/OEO_00420000

Added

Copy link
Contributor

@stap-m stap-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some minor things. The rest looks good to me.

@stap-m
Copy link
Contributor

stap-m commented Feb 24, 2026

The changes mentioned in the description are all made in oeo-model. Yet, there are 20 changes in oeo-co-sim. I think they should not be part of this PR, unless you want them to live there, instead of oeo-model.

schwarzatoffis and others added 3 commits February 26, 2026 10:49
Apply suggestions from review

Co-authored-by: stap-m <38690039+stap-m@users.noreply.github.com>
Copy link
Contributor

@stap-m stap-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made two more small suggestions. The rest looks good now, thanks!

Co-authored-by: stap-m <38690039+stap-m@users.noreply.github.com>
@stap-m stap-m requested a review from Ludee March 3, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

oeo-model changes the oeo-model module

Projects

Status: Review in progress

Development

Successfully merging this pull request may close these issues.

Add simulation scenario

3 participants