fix(asusd): skip failing armoury attributes instead of aborting#144
Open
scardracs wants to merge 1 commit into
Open
fix(asusd): skip failing armoury attributes instead of aborting#144scardracs wants to merge 1 commit into
scardracs wants to merge 1 commit into
Conversation
In start_attributes_zbus, if reload() fails for an attribute, the code logged that it was skipping it, but used break instead of continue. This aborted the entire registration of all subsequent attributes in the directory loop. This patch changes the break to a continue, making individual attribute failures non-fatal, as originally intended. Closes: OpenGamingCollective#132
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In start_attributes_zbus, if reload() fails for an attribute, the code logged that it was skipping it, but used break instead of continue. This aborted the entire registration of all subsequent attributes in the directory loop.
This patch changes the break to a continue, making individual attribute failures non-fatal, as originally intended.
Closes: #132
Signed-off-by: Marco Scardovi scardracs@disroot.org