test(coverage): case-aware path regressions for diff CLI and indoor kits#313
Draft
cursor[bot] wants to merge 1 commit into
Draft
test(coverage): case-aware path regressions for diff CLI and indoor kits#313cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
…orkit Co-authored-by: PuritanWizard <th3w1zard1@users.noreply.github.com>
Contributor
|
Message that will be displayed on users' first pull request |
|
|
||
| from __future__ import annotations | ||
|
|
||
| import json |
Contributor
🔨 Build Validation Summary✅ Version Check: Passed Tool Builds
🎉 All builds validated successfully! This PR is ready for merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risky behavior now covered
is_kotor_install_dir(diff/kotordiff CLI): After PR Case-aware application #151, install detection usesCaseAwarePathso a mismatched directory orchitin.keycasing still resolves on case-sensitive Linux mounts (common in modding/WSL workflows).normalize_path_arg: PowerShell/Steam path quoting edge cases (mangled" path, trailing backslashes, wrapped quotes) — previously untested despite being user-facing CLI input handling.load_kits_unified: Kit folder paths with wrong directory casing no longer silently yield zero kits on Linux.Test files added/updated
Libraries/PyKotor/tests/diff_tool/test_cli_utils.py(new)Libraries/PyKotor/tests/test_indoorkit_case_path.py(new)Why these tests materially reduce regression risk
PR #151 changed production paths to
CaseAwarePathwithout dedicated tests fordiff_tool/cli_utilsortools/indoorkit. A future refactor back to plainPathwould break install detection and kit loading for users on case-sensitive filesystems while appearing fine on Windows CI. These tests follow the same skip pattern astest_talktable.pyfor platform semantics and lock in the intended behavior with minimal fixtures.Validation
13 passed (case-mismatch tests skipped on
win32by design).