test: cover JSON export CI progress and CaseAwarePath cache refresh#314
Draft
cursor[bot] wants to merge 2 commits into
Draft
test: cover JSON export CI progress and CaseAwarePath cache refresh#314cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
Co-authored-by: PuritanWizard <th3w1zard1@users.noreply.github.com>
Co-authored-by: PuritanWizard <th3w1zard1@users.noreply.github.com>
Contributor
|
Message that will be displayed on users' first pull request |
github-actions
Bot
added
python
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risky behavior now covered
resource_json.py): WhenCIorGITHUB_ACTIONSis set, progress must log vialogger.infoinstead of carriage-return stderr updates. Without this, GitHub Actions and log aggregators miss percentage milestones even when stderr reports as a TTY.path.py):clear_cache()after directory structure changes soCaseAwarePathre-resolves segments on POSIX filesystems.Test files added/updated
Libraries/PyKotor/tests/cli/test_json_commands.py— four tests for_supports_live_progressand_ExportProgressReporter(CI vs TTY behavior).Libraries/PyKotor/tests/common/test_case_aware_path.py— POSIX regression forclear_cache()after directory mutations.Why these tests materially reduce regression risk
The JSON export CI fix landed in
c7e573d1dwith only an integration assertion tweak; these unit tests lock the env-gating contract so a future refactor cannot silently restore\rlive updates in automation. The path cache test guards case-aware resolution used by capsules, talk tables, TSLPatcher, and installation tooling after merged PR #151.