Add a Channel Remap Tool#1895
Open
peternewman wants to merge 7 commits intoOpenLightingProject:masterfrom
Open
Add a Channel Remap Tool#1895peternewman wants to merge 7 commits intoOpenLightingProject:masterfrom
peternewman wants to merge 7 commits intoOpenLightingProject:masterfrom
Conversation
This was referenced Aug 28, 2023
kripton
approved these changes
Sep 23, 2024
Member
kripton
left a comment
kripton
left a comment
There was a problem hiding this comment.
The file format/contents could you some more explanatory comments
| } | ||
|
|
||
| uint16_t Channel() const { return m_channel + 1; } | ||
| void Channel(uint16_t channel) { m_channel = channel - 1; } |
Member
There was a problem hiding this comment.
should we limit the channel to valid channel numbers? it's a uint16 but values above 511 proabably don't make sense
| examples/ola_ptch.exe | ||
| examples/ola_patcher_remap | ||
| examples/ola_patcher_remap.exe | ||
| examples/ola_ptcher_remap.exe |
Member
There was a problem hiding this comment.
why do we have the file with the a missing?
| } | ||
|
|
||
| ~DmxRemap() { | ||
| // TODO(Peter): Delete everything |
Member
There was a problem hiding this comment.
should be implemented before merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.