Add protobuf syntax version#1920
Open
kengruven wants to merge 1 commit intoOpenLightingProject:masterfrom
Open
Add protobuf syntax version#1920kengruven wants to merge 1 commit intoOpenLightingProject:masterfrom
kengruven wants to merge 1 commit intoOpenLightingProject:masterfrom
Conversation
kripton
approved these changes
Feb 26, 2024
Member
kripton
left a comment
kripton
left a comment
There was a problem hiding this comment.
Looks reasonable, thanks! @peternewman ?
The protocol buffer spec suggests that this is required. I've tried two protobuf libraries, and one errors without this, and the other prints a warning. There's no documentation in OLA I can find that it's proto2, but it works this way, and it makes sense. Both files use "required", which was removed from proto3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The protocol buffer spec suggests that this is required. I've tried two protobuf libraries, and one errors without this, and the other prints a warning.
There's no documentation in OLA I can find that it's proto2, but it works this way, and it makes sense. Both files use "required", which was removed from proto3.