Issue 1033 - Fix Infinite Payload Range Looping #1034
Open
cmbenne3 wants to merge 18 commits intoOpenMDAO:mainfrom
Open
Issue 1033 - Fix Infinite Payload Range Looping #1034cmbenne3 wants to merge 18 commits intoOpenMDAO:mainfrom
cmbenne3 wants to merge 18 commits intoOpenMDAO:mainfrom
Conversation
… of generate_payload_range
…ault for max_iter
Contributor
|
We should test this as well - the original payload-range test doesn't work using the flag because we needed to get access to the off-design problems in order to check their values. I don't know if we can avoid running the whole payload-range suite twice but if would be nice if we can find a way to do so |
…ll of run_payload_range method. Modify run_payload_range to save the off design problems into the original aviary problem object to enable easier access of off design variables
aviary/validation_cases/benchmark_tests/test_bench_off_design.py
Outdated
Show resolved
Hide resolved
added 4 commits
March 24, 2026 18:07
… after payload_runage run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug where setting payload_range in aviary inputs triggered an infinite looping of trying to generate a payload_range diagram.
The quick fix is to reset the aviary inputs value immediately after generate_payload_range has been set, ahead of running the first off design problem. Unfortunately this leaves mismatched aviary inputs.settings.payload_range = False and prob.generate_payload_range = True for the original parent problem. It is unclear how to fix this without introducing another variable, which seems unecessary!
There is also a small change to grab max_iter from the design/sizing problem and parse that to the optimizer for the off_design problems. This solved an issue where off_design problems failed due to hitting the default max iteration limit (50).
Related Issues
Backwards incompatibilities
None
New Dependencies
None