fix error if ULF_from_maneuver == True#1042
Open
cmbenne3 wants to merge 3 commits intoOpenMDAO:mainfrom
Open
Conversation
Contributor
Author
|
@xjjiang - if this makes more sense to incorporate into one of your PRs let's do that and close this without merging it. |
Member
This bug went uncaught because there wasn't a test, so yes. Testing every branch is never overkill. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a bug that would cause failure if ULF_from_maneuver == True.
local variable max_maneuver_factor was not available at the point in the code where it was required if this branch of logic was triggered.
Do you think we should add tests to design_load.py to test all logic branches or is that overkill for this component?
Related Issues
Backwards incompatibilities
None
New Dependencies
None