Skip to content

Dev stage fixes #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LANDAISB merged 4 commits into from
Jun 4, 2026
Merged

Dev stage fixes #275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a0dcc1d
Split Toplo library into separate categories: hide broken elements, m…
Apr 30, 2026
0f7eca3
update the method named 'toploLibraryCategory'
May 28, 2026
a692c9b
Add status class methods
Jun 1, 2026
60c4259
update list of allowed elements
Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 30 additions & 1 deletion src/Pyramid-Bloc/PyramidLibraryElement.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,28 @@ Class {
#instVars : [
'name',
'icon',
'block'
'block',
'status'
],
#category : #'Pyramid-Bloc-plugin-navigation'
}

{ #category : #accessing }
PyramidLibraryElement class >> statusNotUsable [
^ #notUsable
]

{ #category : #accessing }
PyramidLibraryElement class >> statusOk [

^ #ok
]

{ #category : #accessing }
PyramidLibraryElement class >> statusUnstable [
^ #unstable
]

{ #category : #converting }
PyramidLibraryElement >> asArray [

Expand Down Expand Up @@ -85,3 +102,15 @@ PyramidLibraryElement >> name: anObject [

name := anObject
]

{ #category : #accessing }
PyramidLibraryElement >> status [

^ status ifNil: [self class statusUnstable]
]

{ #category : #accessing }
PyramidLibraryElement >> status: aSymbol [
Copy link
Copy Markdown
Contributor

@LANDAISB LANDAISB May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the different status should be defined on class methods (instead of calling #ok or #unstable, call PyramidLibraryElement statusUnstable). Easier to maintain.


status := aSymbol
]
93 changes: 73 additions & 20 deletions src/Pyramid-Toplo/PyramidToploThemePlugin.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,30 +110,83 @@ PyramidToploThemePlugin class >> toploIconThemeCategoryFromClass: aClass withCat
PyramidToploThemePlugin class >> toploLibraryCategory [

<pyramidLibraryCategory: 1>
| classes elements |
classes := ToElement allSubclasses , { ToElement }.
elements := classes
reject: [ :each |
each isAbstract or: [
(each name findString: 'Abstract') > 0 or: [
[
each new.
false ]
on: Error
do: [ true ] ] ] ]
thenCollect: [ :class |
| allowedClasses allClasses elements knownNotUsable testClass okElements unserializedElements |
allowedClasses := {
ToButton.
ToRadioButton.
ToToggleButton.
ToLabel.
ToImage.
ToAlbum.
ToTextField}.
knownNotUsable := #( #ToCircularMenuInnerElement
Copy link
Copy Markdown
Contributor

@LANDAISB LANDAISB May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why need this list ?

Copy link
Copy Markdown
Collaborator Author

@MagueresMathieu MagueresMathieu Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need this list because these elements cause errors, and the test to create an element and verify if it works does not work for these elements.

#ToCircularMenuList #ToExPicsumNode
#ToAnimatedIcon ).
testClass := Smalltalk at: #ToSerializerTest.
allClasses := ToElement allSubclasses , { ToElement }.
allClasses := allClasses reject: [ :each |
each isAbstract or: [
(each name findString: 'Abstract') > 0 ] ].
elements := allClasses collect: [ :class |
| notUsable serializable status |
notUsable := [
class new.
false ]
on: Error
do: [ :e | true ].
notUsable := notUsable or: [
knownNotUsable includes:
class name asSymbol ].
serializable := [
| suite prefix |
prefix := 'test' , class name.
suite := testClass suite tests
select: [ :t |
t selector beginsWith:
prefix ].
suite isNotEmpty ]
on: Error
do: [ false ].
status := notUsable
ifTrue: [
PyramidLibraryElement statusNotUsable ]
ifFalse: [
((allowedClasses includes: class) and: [
serializable ])
ifTrue: [ PyramidLibraryElement statusOk ]
ifFalse: [
PyramidLibraryElement statusUnstable ] ].
PyramidLibraryElement new
icon:
(Smalltalk ui icons iconNamed: class systemIconName);
icon: (Smalltalk ui icons iconNamed:
(status = PyramidLibraryElement statusNotUsable
ifTrue: [ #error ]
ifFalse: [
status = PyramidLibraryElement statusUnstable
ifTrue: [ #warning ]
ifFalse: [ class systemIconName ] ]));
name: class name;
block: [ { class new } ];
status: status;
yourself ].

^ { (PyramidLibraryCategory new
name: 'Toplo';
icon: (Smalltalk ui icons iconNamed: #box);
elements: (elements sorted: [ :a :b | a name < b name ]);
yourself) }
elements := elements reject: [ :e |
e status = PyramidLibraryElement statusNotUsable ].
okElements := elements select: [ :e |
e status = PyramidLibraryElement statusOk ].
unserializedElements := elements select: [ :e |
e status
= PyramidLibraryElement statusUnstable ].
^ {
(PyramidLibraryCategory new
name: 'Toplo-Verified';
icon: (Smalltalk ui icons iconNamed: #smallOk);
elements: (okElements sorted: [ :a :b | a name < b name ]);
yourself).
(PyramidLibraryCategory new
name: 'Toplo-Unverified';
icon: (Smalltalk ui icons iconNamed: #warning);
elements:
(unserializedElements sorted: [ :a :b | a name < b name ]);
yourself) }
]

{ #category : #adding }
Expand Down
Loading