Open
Conversation
staszczuk
force-pushed
the
pstaszczuk/restore-windows-support
branch
9 times, most recently
from
070e13a to
96e6c39
Compare
staszczuk
force-pushed
the
pstaszczuk/restore-windows-support
branch
2 times, most recently
from
08dcc2f to
2f60cac
Compare
staszczuk
force-pushed
the
pstaszczuk/restore-windows-support
branch
3 times, most recently
from
39cb739 to
0a9659e
Compare
DawidWesierski4
requested review from
DawidWesierski4,
Sakoram,
awilczyns,
moleksy and
soopel
as code owners
staszczuk
force-pushed
the
pstaszczuk/restore-windows-support
branch
3 times, most recently
from
3d91575 to
78ba023
Compare
staszczuk
force-pushed
the
pstaszczuk/restore-windows-support
branch
from
78ba023 to
2000748
Compare
| dprintf(s->dump_fd, "\n"); | ||
| #else | ||
| return; | ||
| #endif |
Collaborator
There was a problem hiding this comment.
this is most likly unnecessary ? and if it is necessary then why?
dprintf is the issue -> fprintf ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.