Skip to content

[Feature request]: Honour OpenFact failures during agent run #614

Description

@bastelfreak

Use Case

Right now an agent run might have broken or missing facts:

[root@ ~]# puppet agent -t
Info: Using environment 'production'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Loading facts
Error: Facter: Error while resolving custom fact fact='docker', resolution='<anonymous>': undefined method `[]' for nil:NilClass
Notice: Requesting catalog from ***:8140 (::1)
Notice: Catalog compiled by ***
Info: Caching catalog for ***
Info: Applying configuration version '1787045723'
Notice: Applied catalog in 0.05 seconds
[root@ ~]# echo $?
0
[root@ ~]

Since the facts might be incomplete, the catalog could be wrong. The exit code doesn't reflect this.

Describe the solution you would like

For OpenVox 9 I would like to see an option to honour OpenFact errors. Maybe a new config option like honour_openfact_errors=true which will trigger a new exit code? Or like the strict setting, you could set it to off, warning or error?

Describe alternatives you've considered

No response

Additional context

No response

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions