Check that slice are in the reserved space in Accumulator push and shift

[Amxx]

No description provided.

[changeset-bot]

🦋 Changeset detected

Latest commit: 1293a76

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
openzeppelin-solidity	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

Walkthrough

The pull request introduces memory reservation validation to the OpenZeppelin Solidity library. Two changeset entries document a minor version bump. A new internal function isReserved(Slice) is added to the Memory utility module to check whether a memory slice is within reserved space. The Accumulators struct operations (push and shift) are updated with runtime guards that validate memory slice reservation, triggering a resource error panic if validation fails. Panic.sol is imported to support error handling. No changes to public function signatures or data structures are made.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No pull request description was provided by the author, making it impossible to assess whether the description relates to the changeset.	Add a description explaining the purpose of the changes, such as why slice validation is necessary and what problems it prevents.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: adding validation to check that slices are in reserved space during Accumulator push and shift operations.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[ernestognw]

Looks good

[ernestognw]

Maybe?

Suggested change

	function testInvalidSlice1() public pure {
	bytes memory input = new bytes(256);
	function testInvalidSliceOutOfBoundEnd(bytes memory input) public pure {

[Amxx]

It will not work. For input objects that have a length that are not a multiple of 32, solidity will set the FMP to a multiple of 32. This means adding 1 is not enough to guarantee the error (because there is more reserved memory than strictly needed)

[ernestognw]

Suggested change

	function testInvalidSlice2() public pure {
	bytes memory input = new bytes(256);
	function testInvalidSlice2(bytes memory input) public pure {

[ernestognw]

Suggested change

	function testInvalidSlice2() public pure {
	function testInvalidSliceOutOfBoundLength() public pure {