[codex] Treat unconfigured LiveKit as optional for voice status#1674
Draft
Jeshua09090 wants to merge 1 commit into
Draft
[codex] Treat unconfigured LiveKit as optional for voice status#1674Jeshua09090 wants to merge 1 commit into
Jeshua09090 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
/api/voice/statusso an unconfigured optional LiveKit service does not make core voice availability reportavailable: falsewhen required STT/TTS services are healthy.Before this change, the endpoint included
livekit: not_configuredin the sameall_healthyaggregation as Whisper and TTS. That made a normal install without LiveKit look partially unavailable even when the required voice path was healthy.The endpoint still reports LiveKit as
not_configured, and a configured but unhealthy LiveKit service still makes the aggregate unavailable.AI Assistance
AI assistance was used to inspect the existing router behavior, write the regression tests first, implement the narrow fix, and run validation. The human author remains responsible for reading the diff and responding to review.
Release Lane
release/2.5.xmainStable hotfix reason:
Changed Surface
Risk And Validation
git diff --checkrelease/2.5.xCommands/results:
Operational Change Check
If this PR touches installer phases, bootstrap logic, compose stack generation,
service manifests, dashboard API control flows, Hermes, model routing, GPU or
runtime detection, lifecycle commands, host mutation, or network exposure, it
requires release-grade fleet validation before release unless the PR explains a
narrower equivalent.
Notes For Reviewers
This only changes aggregation logic for
/api/voice/status. It does not start, stop, configure, or mutate any services. LiveKit remains visible in the response asnot_configured; it simply no longer blocks the core voice availability flag when absent.