Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #208 +/- ##
=======================================
Coverage 95.16% 95.16%
=======================================
Files 253 253
Lines 11706 11707 +1
=======================================
+ Hits 11140 11141 +1
Misses 566 566 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3asm
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refines the vulnerability detection logic for CVE-2024-50379 and updates the corresponding test to use synchronous mocking. The main change ensures that the race condition test is only run if the Tomcat version is vulnerable, improving both accuracy and efficiency.
Vulnerability detection logic:
agent/exploits/cve_2024_50379.py, the code now checks if the Tomcat version is vulnerable before running the race condition test, ensuring the test is only performed when relevant.Testing improvements:
tests/exploits/cve_2024_50379_test.py, the race condition test mock is switched from an asynchronous mock to a synchronous mock to match the updated logic.