Skip to content

fix: CVE_2024_50379#208

Merged
3asm merged 7 commits intomainfrom
fixup-exploit-cve-2024-50379
Dec 18, 2025
Merged

fix: CVE_2024_50379#208
3asm merged 7 commits intomainfrom
fixup-exploit-cve-2024-50379

Conversation

@SalwaAdlouni
Copy link
Copy Markdown
Contributor

@SalwaAdlouni SalwaAdlouni commented Dec 18, 2025

This pull request refines the vulnerability detection logic for CVE-2024-50379 and updates the corresponding test to use synchronous mocking. The main change ensures that the race condition test is only run if the Tomcat version is vulnerable, improving both accuracy and efficiency.

Vulnerability detection logic:

  • In agent/exploits/cve_2024_50379.py, the code now checks if the Tomcat version is vulnerable before running the race condition test, ensuring the test is only performed when relevant.

Testing improvements:

  • In tests/exploits/cve_2024_50379_test.py, the race condition test mock is switched from an asynchronous mock to a synchronous mock to match the updated logic.

@SalwaAdlouni SalwaAdlouni requested a review from a team as a code owner December 18, 2025 15:54
@SalwaAdlouni SalwaAdlouni changed the title impl fix: CVE_2024_50379 Dec 18, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.16%. Comparing base (ec488b9) to head (68a9ad3).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #208   +/-   ##
=======================================
  Coverage   95.16%   95.16%           
=======================================
  Files         253      253           
  Lines       11706    11707    +1     
=======================================
+ Hits        11140    11141    +1     
  Misses        566      566           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@3asm 3asm merged commit ef674a1 into main Dec 18, 2025
7 checks passed
@3asm 3asm deleted the fixup-exploit-cve-2024-50379 branch December 18, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants