You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for the contribution. There are two potential issues worth checking before merging:
Backslash followed by a pipe may break the generated table
For a cell value such as left\|right, the current formatter produces left\\|right. In GFM, the two backslashes resolve to a literal backslash, leaving the pipe to act as a column separator. This can shift columns or drop subsequent values.
Could you verify this case? One possible fix is to escape backslashes before escaping pipes:
.replace(/\\/g,"\\\\").replace(/\|/g,"\\|")
It would also be useful to add a regression test covering \|.
The new test script does not appear to run in CI
test:result-markdown was added to package.json, but the frontend CI workflow runs each test script explicitly and does not currently invoke this one. Could you add a corresponding step to .github/workflows/ci.yml?
The existing formatter test, i18n validation, ESLint, and Community Web build otherwise passed in my local review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
N/A — this is a small, self-contained frontend enhancement without a linked issue.
Summary
Adds a
Markdown tableoption under the query result selection context menu.The formatter:
NULL<br>The new label is localized for English, Chinese, Japanese, Korean, and Spanish. A focused formatter test and package script are included.
Affected surfaces
Verification
yarn run test:result-markdown— passedyarn run test:i18n— passedgit diff --check— passedGET /api/systemthrough the frontend proxy returned HTTP 200.Risk and compatibility
Reviewer map
markdownTable.tsfor formatting rules, thenonContextmenuCell/index.tsfor menu integration.markdownTablecontext-menu entry and its formatter/handler.Contributor declaration
AI assistance: OpenAI Codex assisted with implementation and test drafting; the changes were reviewed and verified locally.