Merged
Conversation
…mGui::GetScroll` not working properly
This was referenced Apr 15, 2025
litelawliet
approved these changes
Apr 30, 2025
Contributor
|
Just to be sure, is it version 1.91.9 or is it 1.91.9b ? |
Member
Author
Not |
This was referenced May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated ImGui to v1.91.9-docking.
The goal of this update is also to keep
ImGuias "vanilla" as possible, instead of modifying its source code like we did in the past.Also updated the
InputManagerto exposeGetMouseScroll, sinceImGui::GetScrollfunction is broken(returns0.0f).GetMouseScrollmethod to LuaRelated Issues
Fixes #121
To-Do
ImGui::GetIO().DisableMouseUpdate(was added by us to ImGui). Wondering if there is a better way to handle that without modifying ImGui's sourcesAddressfollow-up issue: [Regression] Implement a system to programmatically highlight a portion of a plot #448forceHovernot used with plots (PlotHistogramandPlotLines). I recall it was also custom code added to ImGui, can we do without it?layout.ini