Fixed feature set override in shadow, outline, and picking passes#523
Merged
adriengivry merged 3 commits intomainfrom May 16, 2025
Merged
Fixed feature set override in shadow, outline, and picking passes#523adriengivry merged 3 commits intomainfrom
adriengivry merged 3 commits intomainfrom
Conversation
…ew and proj) * Cleaned up shadow rendering code * Updated Engine UBO code to support overriding the view
adriengivry
changed the title
adriengivry
added a commit
that referenced
this pull request
May 16, 2025
* Fixed feature set override in shadow, outline, and picking passes * Removed _LightSpaceMatrix for shadow casting, using ubo instead (view and proj) * Cleaned up shadow rendering code * Updated Engine UBO code to support overriding the view
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Instead of completely overriding the current feature set of a material when rendering a special pass (shadow, outline, picking), this PR ensures the material feature set is preserved, and the feature associated with the pass is added on top.
This way, effects bound to features (e.g. parallax), can still be used during special passes (e.g. shadows).
The engine UBO has been updated to support on-the-fly view/camera changes, this way, the shadow pass can override the view info by providing the light data (will be necessary for reflection probes too).
To-Do
ubo_ViewPos.Related Issue(s)
N/A
Review Guidance
Write here.
Screenshots/GIFs
Write here.