Allow user override of Conventions attribute#960
Merged
Conversation
durack1
reviewed
May 7, 2026
| "Conventions": [ | ||
| "CF-1.11", | ||
| "CF-1.12", | ||
| "CF-1.13" |
Collaborator
There was a problem hiding this comment.
QC checking is synced with this list to-date, see https://esgvoc.ipsl.fr/concept/conventions?projects=cmip7. Would be good to connect if QC changes occur over the phase
durack1
approved these changes
May 7, 2026
Collaborator
There was a problem hiding this comment.
Looks good and syncs with https://esgvoc.ipsl.fr/concept/conventions?projects=cmip7, which is captured in WCRP-CMIP/cmip7-cmor-tables/tables-cvs/cmor-cvs.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #935
This will allow users to set the
Conventionsattribute from their input JSON file. If the user doesn't provide aConventionattribute, then CMOR will get the one provided by the variable table.This is similar behavior that is currently supported by for the
productattribute.