Use capital income tax noncompliance rate in SS etr/mtry diagnostics#1171
Open
marcelolafleur wants to merge 1 commit into
Open
Use capital income tax noncompliance rate in SS etr/mtry diagnostics#1171marcelolafleur wants to merge 1 commit into
marcelolafleur wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1171 +/- ##
=======================================
Coverage 73.37% 73.37%
=======================================
Files 21 21
Lines 5374 5374
=======================================
Hits 3943 3943
Misses 1431 1431
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1170.
One-word fix:
capital_noncompliance_rate_2DinSS.pywas tiled fromp.labor_income_tax_noncompliance_rateinstead ofp.capital_income_tax_noncompliance_rate. This only affects the post-solveetr_ssandmtry_ssdiagnostics in the SS output — the solution itself uses the correct rates viahousehold.pyandtax.py. No behavior change when the two rates are equal (the default).Happy to add a changelog entry and version bump if you'd like them in this PR.