Skip to content

Use capital income tax noncompliance rate in SS etr/mtry diagnostics#1171

Open
marcelolafleur wants to merge 1 commit into
PSLmodels:masterfrom
marcelolafleur:fix/ss-capital-noncompliance-rate
Open

Use capital income tax noncompliance rate in SS etr/mtry diagnostics#1171
marcelolafleur wants to merge 1 commit into
PSLmodels:masterfrom
marcelolafleur:fix/ss-capital-noncompliance-rate

Conversation

@marcelolafleur

Copy link
Copy Markdown
Contributor

Fixes #1170.

One-word fix: capital_noncompliance_rate_2D in SS.py was tiled from p.labor_income_tax_noncompliance_rate instead of p.capital_income_tax_noncompliance_rate. This only affects the post-solve etr_ss and mtry_ss diagnostics in the SS output — the solution itself uses the correct rates via household.py and tax.py. No behavior change when the two rates are equal (the default).

Happy to add a changelog entry and version bump if you'd like them in this PR.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.37%. Comparing base (a12ecf5) to head (cd70d8e).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1171   +/-   ##
=======================================
  Coverage   73.37%   73.37%           
=======================================
  Files          21       21           
  Lines        5374     5374           
=======================================
  Hits         3943     3943           
  Misses       1431     1431           
Flag Coverage Δ
unittests 73.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
ogcore/SS.py 79.02% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SS output "etr" and "mtry" use the labor noncompliance rate in place of the capital rate

2 participants