Skip to content

Conversation

@liyonghua0910
Copy link
Collaborator

@liyonghua0910 liyonghua0910 commented Jan 7, 2026

Motivation

  • 修复 RDMA NICS 脚本在多进程并行时会有临时文件冲突的问题
  • 修复使用 MultiApiServer 启动服务时有概率出现端口明明可用、但可用性检查不通过的问题
  • 增加异常检测和抛出代码

Modifications

Usage or Command

Accuracy Tests

Checklist

  • Add at least a tag in the PR title.
    • Tag list: [[FDConfig],[APIServer],[Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization], [Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [KVCache], [DataProcessor], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others], [XPU], [HPU], [GCU], [DCU], [Iluvatar], [Metax]]
    • You can add new tags based on the PR content, but the semantics must be clear.
  • Format your code, run pre-commit before commit.
  • Add unit tests. Please write the reason in this PR if no unit tests.
  • Provide accuracy results.
  • If the current PR is submitting to the release branch, make sure the PR has been submitted to the develop branch, then cherry-pick it to the release branch with the [Cherry-Pick] PR tag.

@paddle-bot
Copy link

paddle-bot bot commented Jan 7, 2026

Thanks for your contribution!

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@2d2b156). Learn more about missing BASE report.

Files with missing lines Patch % Lines
fastdeploy/entrypoints/openai/multi_api_server.py 37.50% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #5935   +/-   ##
==========================================
  Coverage           ?   67.27%           
==========================================
  Files              ?      348           
  Lines              ?    44672           
  Branches           ?     6877           
==========================================
  Hits               ?    30055           
  Misses             ?    12395           
  Partials           ?     2222           
Flag Coverage Δ
GPU 67.27% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Jiang-Jia-Jun
Jiang-Jia-Jun previously approved these changes Jan 8, 2026
@liyonghua0910 liyonghua0910 changed the title [BugFix] [MultiAPIServer] fix rdma script and add more error log for multi api server [BugFix] [MultiAPIServer] fix rdma script and port check for multi api server Jan 9, 2026
Copy link
Collaborator

@juncaipeng juncaipeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants