feat(specs): Add new security and device profile specs#719
Open
repl-dheeraj-v wants to merge 1 commit intoPaloAltoNetworks:mainfrom
Open
feat(specs): Add new security and device profile specs#719repl-dheeraj-v wants to merge 1 commit intoPaloAltoNetworks:mainfrom
repl-dheeraj-v wants to merge 1 commit intoPaloAltoNetworks:mainfrom
Conversation
- Add data_filtering_security_profile spec with vsys and template locations - Add decryption_profile spec (ssl-inbound-proxy element, correct field names) - Add snmp_trap_profile spec with v2c/v3 variant support - Add email_server_profile spec matching syslog profile structure - Add administrator spec with correct permissions/role-based XML structure - Fix pango error parser to surface raw Panorama response when msg is empty Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Author
|
@migara can you please review. The terraform provider was generated from this and was tested against our configuration |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds five new codegen specs for Terraform provider resources that were missing from the v2 provider, plus a bug fix in the pango error handler.
New Resources
panos_data_filtering_security_profilepanos_decryption_profilepanos_snmp_trap_profilepanos_email_server_profilepanos_administratorBug Fix — pango error parser (
assets/pango/errors/panos.go)When Panorama returns an error response with an empty or unparseable
<msg>element,errors.Parse()previously returned an empty string, causing Terraform to display"failed to create entry on the server: "with no detail. The fix falls back to embedding the raw XML response body in the error so the actual rejection reason is always visible without needingPANOS_LOG_LEVEL=DEBUG.Motivation and Context
These resources exist in the v1 provider but were not yet available in v2. They are required to manage common PAN-OS security and device configurations via Terraform, including SSL/TLS decryption profiles, DLP data filtering, log forwarding via SNMP/email, and administrator account lifecycle.
Key implementation notes:
ssl-inbound-proxy(notssl-inbound-inspectionas in older PAN-OS docs). Verified against PAN-OS 11.2.8 XML API.permissions/role-based/<role>yes</role>XML structure, not a flatroleelement. Thedisabledfield is not valid in this context and was excluded.vsys,template,template-vsys,template-stack, andtemplate-stack-vsyslocations for full NGFW and Panorama template support.How Has This Been Tested?
go run cmd/codegen/main.go)panos_decryption_profile— forward proxy and inbound proxy profiles created at device-group scopepanos_administrator— superuser and superreader accounts created via templateshow config running xpath ...Types of Changes
Checklist