fix(adapter): surface OpenRouter error body instead of KeyError('choices')#42
Merged
Merged
Conversation
…ces')
OpenRouter returns error objects with HTTP 200 for some failures (context
length exceeded, provider moderation). The adapter crashed with an opaque
KeyError('choices'); now it raises RuntimeError with the provider's actual
error message. Found live when gpt-oss-120b (131k context) hit the ~184k-token
operations tasks.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpenRouter returns error objects with HTTP 200 for some failures (context length exceeded, provider moderation). The adapter crashed with an opaque
KeyError('choices'); it now raisesRuntimeErrorcarrying the provider's actual error message.Found live during the official leaderboard run:
openai/gpt-oss-120b(131k context) hit the ~184k-token operations tasks and every failure logged asFAILED ('choices')with no hint of the real cause.Tests
test_error_body_with_200_surfaces_provider_message— error body + HTTP 200 → RuntimeError with provider messagetest_empty_choices_list_raises_runtime_error— empty choices list → legible RuntimeError🤖 Generated with Claude Code