feat: adding workflow to verify that changelog.d entries have been added. - #17
Open
Squirrel18 wants to merge 19 commits into
Open
feat: adding workflow to verify that changelog.d entries have been added.#17Squirrel18 wants to merge 19 commits into
Squirrel18 wants to merge 19 commits into
Conversation
Squirrel18
marked this pull request as draft
January 16, 2026 22:36
Squirrel18
marked this pull request as ready for review
January 19, 2026 16:42
MAAngamarca
approved these changes
Jan 28, 2026
|
LGTM. |
Contributor
Author
Are you suggesting it to avoid direct changes in the CHANGELOG.md file? or why are you suggesting it? @MAAngamarca |
|
yes, to avoid direct changes in that file. @Squirrel18 |
Squirrel18
force-pushed
the
dqe/check-scriv-entries
branch
from
February 4, 2026 15:53
dd7cfaf to
97330b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR is part of the new release process: #10 and adds a new workflow to verify that changelog.d entries have been added as part of the changes in a PR. All changes in a PR should include an entry describing the nature of the change using Scriv, this enforces Scriv to be used, maintaining an up-to-date changelog and applying good practices when opening PRs.
Test:
Notes:
github.head_refto the checkout Action so it can use the branch of the PR instead of the SHA ref.grep -q "^changelog\.d/.*\.md$". To make this more robust, we would require to interact with Scriv file naming pattern increasing the complexity of this Action. For now this is the least we can do to perform the check.Reviewers: