Skip to content

Allow plus signs #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tsalo wants to merge 4 commits into
base: main
Choose a base branch
from
+674 −160
Draft

Allow plus signs #450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bc5e3e2
Update schema to support plus signs.
tsalo Mar 3, 2025
02ae698
Account for plus signs in entity values.
tsalo Mar 3, 2025
68deabd
Raise exception if no matching files found.
tsalo Mar 3, 2025
4a1fc36
Merge branch 'main' into allow-plus-signs
tsalo Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cubids/cubids.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1010,10 +1010,14 @@ def get_param_groups_from_entity_set(self, entity_set):
raise Exception("Fieldmaps must be cached to find parameter groups.")
key_entities = utils._entity_set_to_entities(entity_set)
key_entities["extension"] = ".nii[.gz]*"
# Account for plus signs in entity values
key_entities = {k: v.replace("+", "\\+") for k, v in key_entities.items() if v is not None}

matching_files = self.layout.get(
return_type="file", scope="self", regex_search=True, **key_entities
)
if not matching_files:
raise Exception(f"No files found for entity set: {key_entities}")

# ensure files who's entities contain key_entities but include other
# entities do not also get added to matching_files
Expand Down
Loading