compute the correct varname for control character variables starting with _ #24136
+32
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The change looks good to me, but shouldn't there be tests for the 5 fixed variables? |
…with _ This also fixes the issue for the remaining (and unused) control character variables $^[ $^\ $^] $^^ Fixes GH #24135.
khwilliamson
approved these changes
Jan 29, 2026
Contributor
Author
Just added a test, but besides |
Contributor
Author
|
Made another fix to |
Contributor
Author
|
Do these changes require a perldelta entry? I suppose so, if they change warning output. |
mauke
reviewed
Jan 31, 2026
I.e. varname should return ${^FOO} and not $^FOO.
book
force-pushed
the
book/gh24135
branch
2 times, most recently
from
e247da6 to
1bc27e0
Compare
jkeenan
requested changes
Feb 8, 2026
tonycoz
reviewed
Feb 9, 2026
| version - ie substr($name, 1, 1) = $buffer; */ | ||
| sv_insert(name, 1, 1, buffer, 2); | ||
| version - ie substr($name, 1, 1) = $buffer; | ||
| wrap in { } if the name is longer than 1 character */ |
Contributor
There was a problem hiding this comment.
New line uses a tab for indentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes the issue for the remaining (and unused) control character variables:
$^[,$^\,$^],$^^.Fixes GH #24135.