Skip to content

Fixed the issue that the time for units in the area guard mission to reacquire targets after eliminating the target is significantly longer than that in other missions#2085

Merged
Coronia merged 2 commits intoPhobos-developers:developfrom
TaranDahl:AreaGuardTargetExpired
Apr 24, 2026

Conversation

@TaranDahl
Copy link
Copy Markdown
Contributor

No description provided.

@TaranDahl TaranDahl added ❓Vanilla bug Vanilla game bugs that are requested to be fixed Tested ⚙️T1 T1 maintainer review is sufficient Bugfix This is a bugfix that does not need documentation beyond mention in changelog labels Feb 4, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 4, 2026

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@TaranDahl
Copy link
Copy Markdown
Contributor Author

Bounty: 10 CNY for the 1st reviewer who gives valid review
image

@Coronia
Copy link
Copy Markdown
Contributor

Coronia commented Feb 11, 2026

not sure if this is really an issue. Looks like Westwood did it in this way deliberately. but idk their reason nor if there's any side effect of changing this

@TaranDahl
Copy link
Copy Markdown
Contributor Author

not sure if this is really an issue. Looks like Westwood did it in this way deliberately.

I'm more inclined to think that the code for the AreaGuard part was written by another coder. Due to unfamiliarity with the original enemy-detection process, he reinvented the wheel and also introduced new problems.

but idk their reason nor if there's any side effect of changing this

I see no side effects so far. Mission AreaGuard seemingly only changes target, destination, etc.

@TaranDahl TaranDahl requested a review from Coronia April 16, 2026 13:05
@TaranDahl
Copy link
Copy Markdown
Contributor Author

not sure if this is really an issue. Looks like Westwood did it in this way deliberately.

I checked the code of RA1.
In RA1, all target searching operations are completed within Missions (Move, Guard, Hunt, AreaGuard).
In RA2, the target searching functions of Move and Guard have both been integrated into the unit's own Update and managed by independent timers.
I believe they simply overlooked AreaGuard.

@TaranDahl TaranDahl added the Will be merged in 24h This PR will be merged in 24 hours if no one has further instructions. label Apr 23, 2026
@Coronia Coronia merged commit 2f90938 into Phobos-developers:develop Apr 24, 2026
9 checks passed
@TaranDahl
Copy link
Copy Markdown
Contributor Author

TaranDahl commented Apr 24, 2026

Bonuty transferred.

@TaranDahl TaranDahl deleted the AreaGuardTargetExpired branch April 24, 2026 17:20
DeathFishAtEase added a commit to DeathFishAtEase/Phobos that referenced this pull request Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bounty available Bugfix This is a bugfix that does not need documentation beyond mention in changelog ⚙️T1 T1 maintainer review is sufficient Tested ❓Vanilla bug Vanilla game bugs that are requested to be fixed Will be merged in 24h This PR will be merged in 24 hours if no one has further instructions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants