feat(lock): introduce LockConfiguration for configurable lock timing#11
Merged
tshan10 merged 5 commits intoPhonePe:mainfrom Apr 13, 2026
Merged
Conversation
tshan10
reviewed
Apr 10, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Lock timing (TTL, wait timeout, retry interval) was hardcoded in
LockBase,giving consumers no way to tune behaviour for their SLOs. This PR introduces
LockConfiguration— a simple, immutable config object — to make thesevalues configurable per instance
Motivation
Services have widely different SLOs. A payment service may need a 30 s TTL with a
500 ms retry interval; a batch job can tolerate the 90 s defaults. Previously, the
only way to override these values was to pass explicit
Durationarguments on everyacquireLockcall — error-prone and inconsistent across a codebase.Changes
LockConfiguration— new@Buildervalue object with threeDurationfields (
lockTtl,waitForLock,retryInterval) and sensible@Builder.Defaultvalues matching the existing hardcoded constants
LockBase— wires inLockConfiguration; removes the old static constantsLockConfigurationTest— 7 unit tests covering defaults, custom values,partial config, and builder backward compat
README— documents the new configuration optionJavadocs— updated to reference LockConfiguration for default valuesBackward Compatibility
Zero breaking changes. Existing
LockBase.builder()calls compile and behaveidentically — defaults are preserved via
@Builder.Default.