Merged
Conversation
d162b09 to
fd6c456
Compare
1f600d3 to
a6da710
Compare
- When building the docker images, in the verify step, use C++14 on Ubuntu 20.04 - Use MSVC 2022 instead of MSVC 2019 on the Win 64bit CI - Install nanoflann in the docker images (not available in Ubuntu 20.04) - Install cjson in the release docker images
larshg
approved these changes
Mar 3, 2025
Contributor
|
What was the reason why .net 4.8.x didn't work with openni2? |
Member
Author
With 4.8.1 it said Not sure if the 4.7.2 version is hardcoded somewhere in the OpenNI2 code? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft.Net.Component.4.8to the 4.7.2 version, otherwise openni2 would not build. I am not sure if that could have any downsides, but it seems okay?To be squashed upon merge.