Skip to content

Update/improve CI#6242

Merged
mvieth merged 11 commits intoPointCloudLibrary:masterfrom
mvieth:update_ci2
Mar 4, 2025
Merged

Update/improve CI#6242
mvieth merged 11 commits intoPointCloudLibrary:masterfrom
mvieth:update_ci2

Conversation

@mvieth
Copy link
Copy Markdown
Member

@mvieth mvieth commented Feb 26, 2025

  • When building the docker images, in the verify step, use C++14 on Ubuntu 20.04 (necessary for that CUDA version)
  • Use MSVC 2022 instead of MSVC 2019 on the Win 64bit CI (this also fixes the build of qtbase)
  • Install nanoflann in the docker images (not available in Ubuntu 20.04)
  • Install cjson in the release docker images
  • When installing vtk via vcpkg, disable the default features to save some build time and avoid the 6h timeout. As far as I can tell, we do not need any of those default features or the dependencies they drag in. Vcpkg disables them as well when vtk is built as a dependency of pcl: https://github.com/microsoft/vcpkg/blob/master/ports/pcl/vcpkg.json#L117
  • I only got the build to work after switching Microsoft.Net.Component.4.8 to the 4.7.2 version, otherwise openni2 would not build. I am not sure if that could have any downsides, but it seems okay?

To be squashed upon merge.

@mvieth mvieth force-pushed the update_ci2 branch 3 times, most recently from d162b09 to fd6c456 Compare February 28, 2025 09:01
@mvieth mvieth marked this pull request as draft February 28, 2025 09:02
@mvieth mvieth force-pushed the update_ci2 branch 3 times, most recently from 1f600d3 to a6da710 Compare February 28, 2025 10:55
- When building the docker images, in the verify step, use C++14 on Ubuntu 20.04
- Use MSVC 2022 instead of MSVC 2019 on the Win 64bit CI
- Install nanoflann in the docker images (not available in Ubuntu 20.04)
- Install cjson in the release docker images
@mvieth mvieth marked this pull request as ready for review March 3, 2025 15:55
@mvieth mvieth requested a review from larshg March 3, 2025 15:55
@larshg
Copy link
Copy Markdown
Contributor

larshg commented Mar 3, 2025

What was the reason why .net 4.8.x didn't work with openni2?

@mvieth
Copy link
Copy Markdown
Member Author

mvieth commented Mar 4, 2025

What was the reason why .net 4.8.x didn't work with openni2?

With 4.8.1 it said Could not find <cor.h>. Ensure the NETFXSDK is installed.
With 4.8 it said error MSB3644: The reference assemblies for .NETFramework,Version=v4.7.2 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks [C:\b\openni2\x64-windows-rel-rel\Source\Drivers\Kinect\Kinect.vcxproj]

Not sure if the 4.7.2 version is hardcoded somewhere in the OpenNI2 code?

@mvieth mvieth merged commit 9079226 into PointCloudLibrary:master Mar 4, 2025
19 checks passed
@mvieth mvieth deleted the update_ci2 branch March 4, 2025 08:14
@mvieth mvieth added the changelog: enhancement Meta-information for changelog generation label Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: enhancement Meta-information for changelog generation module: ci

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants