feat(mobile): add Scout as an inbox signal source (port #2505)#2521
Merged
Conversation
Contributor
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
apps/mobile/src/features/inbox/stores/inboxFilterStore.test.ts:18-28
The team prefers parameterized tests (`it.each`). Since the toggle logic is identical for every `SourceProduct` value, expressing this as a table-driven test makes it trivial to extend when new products are added and makes the intent explicit. The two assertions (toggle on / toggle off) still map naturally to two rows.
```suggestion
it.each<SourceProduct>(["signals_scout", "error_tracking", "github"])(
"toggles %s in and out of the source filter",
(source) => {
const { toggleSourceProduct } = useInboxFilterStore.getState();
toggleSourceProduct(source);
expect(useInboxFilterStore.getState().sourceProductFilter).toEqual([
source,
]);
toggleSourceProduct(source);
expect(useInboxFilterStore.getState().sourceProductFilter).toEqual([]);
},
);
```
Reviews (1): Last reviewed commit: "feat(mobile): add Scout as an inbox sign..." | Re-trigger Greptile |
charlesvien
approved these changes
Jun 10, 2026
Make the mobile inbox aware of the `signals_scout` source product so Scout-sourced signal reports display and filter correctly. - Add `"signals_scout"` to the `SourceProduct` union in the inbox filter store - Add a "Scout" option to the FilterSheet source options - Render the Compass icon and a "Scout · Cross-source issue" / "Scout" label in SignalCard Ports #2505 to apps/mobile. Generated-By: PostHog Code Task-Id: 9218c738-5580-4836-acd6-4a220919cc8a
Convert the source-filter toggle test to a table-driven `it.each` over multiple SourceProduct values, per team preference. Makes it trivial to extend as new source products are added. Generated-By: PostHog Code Task-Id: 9218c738-5580-4836-acd6-4a220919cc8a
14e1298 to
b4de3ea
Compare
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
charlesvien
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports #2505 ("feat(signals): add Scouts as a signal source in the inbox") to the mobile app.
Makes the mobile inbox aware of the
signals_scoutsource product (displayed as "Scout", with a Compass icon) so Scout-sourced signal reports display and filter correctly.Changes (
apps/mobile)features/inbox/stores/inboxFilterStore.ts— add"signals_scout"to theSourceProductunion.features/inbox/components/FilterSheet.tsx— add{ value: "signals_scout", label: "Scout" }to the source options.features/inbox/components/SignalCard.tsx— add asignals_scoutcase to theSourceIconswitch (Compass icon, consistent with the other phosphor icons) and render a "Scout · Cross-source issue" / "Scout" label insourceLine().features/inbox/stores/inboxFilterStore.test.ts— test toggling the new source on/off.Pure renderer/UI surface — no main-process or business-logic changes. Desktop (
apps/code) code is untouched.Testing
pnpm --filter mobile test src/features/inbox/stores/inboxFilterStore.test.tspasses.