Skip to content

feat(mobile): add Scout as an inbox signal source (port #2505)#2521

Merged
charlesvien merged 2 commits into
mainfrom
posthog-code/mobile-scout-signal-source
Jun 10, 2026
Merged

feat(mobile): add Scout as an inbox signal source (port #2505)#2521
charlesvien merged 2 commits into
mainfrom
posthog-code/mobile-scout-signal-source

Conversation

@Gilbert09

Copy link
Copy Markdown
Member

Summary

Ports #2505 ("feat(signals): add Scouts as a signal source in the inbox") to the mobile app.

Makes the mobile inbox aware of the signals_scout source product (displayed as "Scout", with a Compass icon) so Scout-sourced signal reports display and filter correctly.

Changes (apps/mobile)

  • features/inbox/stores/inboxFilterStore.ts — add "signals_scout" to the SourceProduct union.
  • features/inbox/components/FilterSheet.tsx — add { value: "signals_scout", label: "Scout" } to the source options.
  • features/inbox/components/SignalCard.tsx — add a signals_scout case to the SourceIcon switch (Compass icon, consistent with the other phosphor icons) and render a "Scout · Cross-source issue" / "Scout" label in sourceLine().
  • features/inbox/stores/inboxFilterStore.test.ts — test toggling the new source on/off.

Pure renderer/UI surface — no main-process or business-logic changes. Desktop (apps/code) code is untouched.

Testing

  • pnpm --filter mobile test src/features/inbox/stores/inboxFilterStore.test.ts passes.
  • Biome formatting/lint clean on the changed files.

@Gilbert09 Gilbert09 requested a review from a team June 8, 2026 10:35
@greptile-apps

greptile-apps Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
apps/mobile/src/features/inbox/stores/inboxFilterStore.test.ts:18-28
The team prefers parameterized tests (`it.each`). Since the toggle logic is identical for every `SourceProduct` value, expressing this as a table-driven test makes it trivial to extend when new products are added and makes the intent explicit. The two assertions (toggle on / toggle off) still map naturally to two rows.

```suggestion
  it.each<SourceProduct>(["signals_scout", "error_tracking", "github"])(
    "toggles %s in and out of the source filter",
    (source) => {
      const { toggleSourceProduct } = useInboxFilterStore.getState();

      toggleSourceProduct(source);
      expect(useInboxFilterStore.getState().sourceProductFilter).toEqual([
        source,
      ]);

      toggleSourceProduct(source);
      expect(useInboxFilterStore.getState().sourceProductFilter).toEqual([]);
    },
  );
```

Reviews (1): Last reviewed commit: "feat(mobile): add Scout as an inbox sign..." | Re-trigger Greptile

Comment thread apps/mobile/src/features/inbox/stores/inboxFilterStore.test.ts Outdated
@Gilbert09 Gilbert09 added the Stamphog This will request an autostamp by stamphog on small changes label Jun 9, 2026

@stamphog stamphog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review agent failed after 3 attempts — needs human review.

@stamphog stamphog Bot removed the Stamphog This will request an autostamp by stamphog on small changes label Jun 9, 2026
Gilbert09 added 2 commits June 9, 2026 22:00
Make the mobile inbox aware of the `signals_scout` source product so
Scout-sourced signal reports display and filter correctly.

- Add `"signals_scout"` to the `SourceProduct` union in the inbox filter store
- Add a "Scout" option to the FilterSheet source options
- Render the Compass icon and a "Scout · Cross-source issue" / "Scout" label
  in SignalCard

Ports #2505 to apps/mobile.

Generated-By: PostHog Code
Task-Id: 9218c738-5580-4836-acd6-4a220919cc8a
Convert the source-filter toggle test to a table-driven `it.each` over
multiple SourceProduct values, per team preference. Makes it trivial to
extend as new source products are added.

Generated-By: PostHog Code
Task-Id: 9218c738-5580-4836-acd6-4a220919cc8a
@charlesvien charlesvien force-pushed the posthog-code/mobile-scout-signal-source branch from 14e1298 to b4de3ea Compare June 10, 2026 05:02
@charlesvien charlesvien enabled auto-merge (squash) June 10, 2026 05:02
@github-actions

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit b4de3ea.

@charlesvien charlesvien disabled auto-merge June 10, 2026 05:02
@charlesvien charlesvien enabled auto-merge (squash) June 10, 2026 05:03
@charlesvien charlesvien merged commit c2539cb into main Jun 10, 2026
19 checks passed
@charlesvien charlesvien deleted the posthog-code/mobile-scout-signal-source branch June 10, 2026 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants