Skip to content

feat(code): show scout name on signal cards - #2538

Merged
andrewm4894 merged 1 commit into
mainfrom
feat/scout-name-on-signal-card
Jun 9, 2026
Merged

feat(code): show scout name on signal cards#2538
andrewm4894 merged 1 commit into
mainfrom
feat/scout-name-on-signal-card

Conversation

@andrewm4894

Copy link
Copy Markdown
Member

Problem

Scout-emitted signals on a report all rendered the same generic source line — Scout · Cross-source issue — so there was no way to tell which scout produced a given finding. Every scout (error tracking, logs, revenue, LLM analytics, etc.) emits with the same source_product/source_type pair, so the taxonomy alone can't distinguish them.

Changes

Surface the emitting scout's name on each signal card. The scout's skill_name already reaches the frontend inside the signal's extra payload (SignalsScoutSignalExtra), so this is a display-only change — no backend, API, or type plumbing needed.

  • Added prettifyScoutName() — strips the signals-scout- prefix and sentence-cases the rest (e.g. signals-scout-error-trackingError tracking).
  • The scout branch of signalCardSourceLine() now renders Scout · <name>, falling back to the previous Scout · Cross-source issue label when skill_name is absent.
  • Normalized extra at the call site (parseExtra) since it can arrive as a raw JSON string.

Single file touched: apps/code/src/renderer/features/inbox/components/detail/SignalCard.tsx.

How did you test this?

  • tsc typecheck — no errors in SignalCard.tsx.
  • Manual reasoning over the source-line logic; fallback preserves prior behavior for signals without skill_name.

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Scout-emitted signals all rendered the generic "Scout · Cross-source
issue" source line, making it impossible to tell which scout produced a
finding on a report. The scout's skill_name already reaches the frontend
in the signal's extra payload, so surface it: render "Scout · <name>"
(e.g. "Scout · Error tracking"), falling back to the old label when
skill_name is absent.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@andrewm4894 andrewm4894 self-assigned this Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit d95788f.

@andrewm4894
andrewm4894 requested a review from a team June 9, 2026 07:10
@greptile-apps

greptile-apps Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Comments Outside Diff (1)

  1. apps/code/src/renderer/features/inbox/components/detail/SignalCard.tsx, line 147-149 (link)

    P2 Missing typed interface for scout extra payload. Every other source-specific extra has a dedicated interface (GitHubIssueExtra, LlmEvalExtra, etc.). Adding one here keeps the pattern consistent and makes it easier to extend the card with more scout fields later.

    Prompt To Fix With AI
    This is a comment left during a code review.
    Path: apps/code/src/renderer/features/inbox/components/detail/SignalCard.tsx
    Line: 147-149
    
    Comment:
    Missing typed interface for scout `extra` payload. Every other source-specific extra has a dedicated interface (`GitHubIssueExtra`, `LlmEvalExtra`, etc.). Adding one here keeps the pattern consistent and makes it easier to extend the card with more scout fields later.
    
    
    
    How can I resolve this? If you propose a fix, please make it concise.

    Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
apps/code/src/renderer/features/inbox/components/detail/SignalCard.tsx:147-149
Missing typed interface for scout `extra` payload. Every other source-specific extra has a dedicated interface (`GitHubIssueExtra`, `LlmEvalExtra`, etc.). Adding one here keeps the pattern consistent and makes it easier to extend the card with more scout fields later.

```suggestion
interface ErrorTrackingExtra {
  fingerprint?: string;
}

interface SignalsScoutExtra {
  skill_name?: string;
}
```

Reviews (1): Last reviewed commit: "feat(code): show scout name on signal ca..." | Re-trigger Greptile

@andrewm4894
andrewm4894 merged commit f1bbd22 into main Jun 9, 2026
16 checks passed
@andrewm4894
andrewm4894 deleted the feat/scout-name-on-signal-card branch June 9, 2026 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants