fix(scouts): move the linked-report chip beside the task-run link#2701
Merged
Conversation
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
|
Reviews (1): Last reviewed commit: "fix(scouts): show a 'Not in a report' st..." | Re-trigger Greptile |
The linked-report chip sat on the left after the finding id, and an unlinked finding fell back to a noisy "Sent to the signals pipeline …" note. Move the chip to the footer's right edge next to the task-run link, and drop the note: with the backend lookup fixed (PostHog/posthog#63983) a finding shows the chip when it's linked and simply nothing when it isn't.
andrewm4894
force-pushed
the
fix/scout-finding-report-link-fallback
branch
from
June 16, 2026 12:35
5404c9c to
e0c7cd1
Compare
andrewm4894
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e0c7cd1f3f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
andrewm4894
added
the
Stamphog
andrewm4894
enabled auto-merge (squash)
June 16, 2026 12:51
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
On the scout detail page, the linked-report chip sat on the left (right after the finding id), and an unlinked finding fell back to a noisy "Sent to the signals pipeline – report assignment isn't traceable here yet" note.
This moves the chip to the footer's right edge, next to the "Open task run" link, and drops the fallback note entirely:
In report: …chip, beside the task-run linkWhy
The fallback note was effectively dead/ugly: on this surface
footerEnd(the task-run link) is always present, so the report indicator and the task-run link belong together on the right. With the backend lookup bug fixed in PostHog/posthog#63983, a finding reliably shows the chip when its signal is linked to a report — so an unlinked finding simply showing nothing is the right call.Test plan
pnpm --filter @posthog/ui typecheckpassesScoutEmissionCard.tsx); footer layout otherwise unchanged