fix(channels): sidebar overflow, archive, tooltips, private-task filtering, and bluebird cmd-k routing#2715
Merged
Conversation
…ering, and bluebird cmd-k routing Channels sidebar UX fixes: - Truncate task names so long titles no longer cause horizontal scroll. - Add an "Archive" option to the task right-click context menu. - Hide archived tasks from channel listings. - Hide tasks filed by other users (not shared with me) instead of rendering them as "Untitled task". - Show the full task name in a delayed tooltip on hover. - Show a "+" new-channel button on hover over the "Channels" header, scoped to the header row only. - Match the channel-name icon spacing to other sidebar rows. CMD-K: when project-bluebird is enabled, selecting a task that is filed to a channel routes to the channel-organized view under /website rather than /code. Generated-By: PostHog Code Task-Id: b3d24fd9-abfb-42b8-9efb-f83760f0d3f1
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
packages/ui/src/features/canvas/components/ChannelsList.tsx:270-278
**Archive doesn't navigate away when viewing the task in channel view**
`archiveTask` calls `navigateAwayFromTaskIfActive`, which checks `getAppViewSnapshot().type === "task-detail"`. But `deriveFromMatches` in `useAppView.ts` only maps `/code/tasks/$taskId` to `"task-detail"` — the `/website/$channelId/tasks/$taskId` route falls through to the `default` branch and returns `"task-input"`. So when a user is viewing a channel task at `/website/…/tasks/$taskId` and archives it from this context menu, the stale task detail stays visible in the main pane; no navigation fires. Adding `case "/website/$channelId/tasks/$taskId"` (returning `{ type: "task-detail", taskId }`) to `deriveFromMatches` would fix this.
Reviews (1): Last reviewed commit: "fix(channels): sidebar overflow, archive..." | Re-trigger Greptile |
deriveFromMatches only mapped /code/tasks/$taskId to "task-detail", so archiving a task while viewing it at /website/$channelId/tasks/$taskId left the stale detail in the main pane — navigateAwayFromTaskIfActive never fired. Map the channels-space task route to the same view. Generated-By: PostHog Code Task-Id: b3d24fd9-abfb-42b8-9efb-f83760f0d3f1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A batch of small UX fixes for the channels sidebar, plus a CMD-K routing change for the
project-bluebirdflag.Channels sidebar
+on the "Channels" header — opens the new-channel modal; the affordance only appears when hovering the header row itself, not the section below it.CMD-K
project-bluebirdis enabled, selecting a task that is filed to a channel routes to the channel-organized view under/website/$channelId/tasks/$taskIdinstead of/code/tasks/$taskId. Non-bluebird users are unaffected.Testing
Created with PostHog Code